Skip to content

feat(tabs): register tabs elements #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2019
Merged

feat(tabs): register tabs elements #1883

merged 2 commits into from
Jul 2, 2019

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Jul 1, 2019

Also, add a tabs component tests-app-ng.

PR Checklist

What is the current behavior?

A TabView widget is available.

What is the new behavior?

Register new widgets:

  • BottomNavigation
  • TabStrip
  • TabStripItem
  • TabContentItem
  • Tabs

Relates to NativeScript/NativeScript#6967.

@vchimev vchimev requested a review from vakrilov July 2, 2019 07:29
@vchimev vchimev merged commit 092a833 into master Jul 2, 2019
@vchimev vchimev deleted the vchimev/tabs branch July 2, 2019 08:04
zbranzov pushed a commit that referenced this pull request Jul 5, 2019
* chore: bump version

* Update zone.js peer dependency

* update zone.js in all apps

* Make repo apps compatible with `--bundle` (#1857)

* chore: upgrade app to latest versions and webpack

* chore: fix incorrect temlateUrl in component
chore: update karma config for latest CLI beta 6.0.0

* chore: make `router-tab-view` example webpack compatible

* chore: make `nested-router-tab-view` example webpack compatible

* chore: fix lazy loaded component not loading

* chore: make `modal-navigation-ng` example webpack compatible

* chore: add webpack config due to issue in CLI that disregards the `nsconfig.json`

* chore: update test app with latest deps and remove not used d.ts

* chore: update karma config

* chore: resolve issue caused by overrding `global.__extends `

* chore: update Angular deps

* chore: update `nativescript-dev-webpack` to next

* refactor: unit-test configs

* test: update webpack config

* refactor: remove deprecated API usage (#1874)

* tests: mocha reporter and include ts files (#1875)

* Migrate from ReflectiveInjector (deprecated) to StaticInjector (#1868)

* chore: migrate to StaticInjector

* chore: replace parentInjector in detached-loader

* feat(tabs): register tabs elements (#1883)

* feat(tabs): register tabs elements

* feat(tests-app-ng): add tabs component

* chore: fix android28 animation tests (#1885)

* chore: retry a flaky test on failure (#1886)

* release: cut the 8.0.2 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants